Improve documentation of convert_java_nondet #3092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
NathanJPhillips,
cesaro,
cristina-david,
peterschrammel,
pkesseli and
thk123
as code owners
owen-mc-diffblue
approved these changes
Oct 3, 2018
In particular highlight the need to run remove_java_new *after* this pass.
smowton
force-pushed
the
smowton/doc/convert-java-nondet
branch
from
64275eb to
025016a
Compare
allredj
reviewed
Oct 3, 2018
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 025016a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86756028
peterschrammel
approved these changes
Oct 3, 2018
| /// \param message_handler: For error logging. | ||
| /// \param object_factory_parameters: Parameters for the generation of nondet | ||
| /// objects. | ||
| /// \param mode: Mode for newly created symbols |
Member
There was a problem hiding this comment.
Surprised that this isn't always ID_java?
Contributor
Author
There was a problem hiding this comment.
Me too, but that's another PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular highlight the need to run
remove_java_newafter this pass.[ ] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.[ ] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message)[ ] My commit message includes data points confirming performance improvements (if claimed).