Skip to content

Conversation

@tautschnig
Copy link
Collaborator

8a37a2d made what() virtual, but failed to add a virtual destructor.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

8a37a2d made what() virtual, but failed to add a virtual destructor.
@tautschnig tautschnig self-assigned this Nov 10, 2018
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 6e37d0e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90945382

@tautschnig tautschnig merged commit c6ae7cc into diffblue:develop Nov 10, 2018
@tautschnig tautschnig deleted the missing-virt-dest branch November 10, 2018 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants