Avoid shadowing in custom bitvector analysis [blocks: #2310] #3354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue,
martin-cs,
peterschrammel,
smowton and
thk123
as code owners
allredj
reviewed
Nov 10, 2018
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 59318d8).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90958232
kroening
approved these changes
Nov 11, 2018
peterschrammel
approved these changes
Nov 11, 2018
| for(const auto &pointer : pointer_set) | ||
| if(pointer.type().id()==ID_pointer) | ||
| result.insert(dereference_exprt(pointer)); | ||
| for(const auto &p : pointer_set) |
Member
There was a problem hiding this comment.
I'd have preferred not using undescriptive, one-letter variable names.
Collaborator
Author
There was a problem hiding this comment.
Thanks for forcing me not to be lazy :-) - I've gone for "alias", and also renamed "pointer_set" to "alias_set."
Remove uninformative temporaries and rename locals.
tautschnig
force-pushed
the
vs-shadow-5
branch
from
59318d8 to
df10896
Compare
tautschnig
assigned
tautschnig and unassigned
smowton,
peterschrammel,
martin-cs and
chrisr-diffblue
allredj
reviewed
Nov 11, 2018
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: df10896).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90981869
smowton
approved these changes
Nov 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove uninformative temporaries and rename locals.