Skip to content

Do not shadow "type" function parameter [blocks: #2310] #3360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kroening merged 1 commit into from
Nov 11, 2018
Merged

Do not shadow "type" function parameter [blocks: #2310] #3360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/ansi-c/c_typecheck_type.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,13 +439,13 @@ void c_typecheck_baset::typecheck_code_type(code_typet &type)
code_typet::parametert parameter;

// first fix type
typet &type=parameter.type();
type=declaration.full_type(declaration.declarator());
typet &param_type = parameter.type();
param_type = declaration.full_type(declaration.declarator());
std::list<codet> tmp_clean_code;
tmp_clean_code.swap(clean_code); // ignore side-effects
typecheck_type(type);
typecheck_type(param_type);
tmp_clean_code.swap(clean_code);
adjust_function_parameter(type);
adjust_function_parameter(param_type);

// adjust the identifier
irep_idt identifier=declaration.declarator().get_name();
Expand All @@ -459,7 +459,7 @@ void c_typecheck_baset::typecheck_code_type(code_typet &type)
else
{
// make visible now, later parameters might use it
parameter_map[identifier]=type;
parameter_map[identifier] = param_type;
parameter.set_base_name(declaration.declarator().get_base_name());
parameter.add_source_location()=
declaration.declarator().source_location();
Expand Down