Skip to content

Conversation

@tautschnig
Copy link
Collaborator

There is no bounded model checking expected or required by these tests, and also
they use GCC-specific built-ins. There is still work left to be done, so most
remain KNOWNBUG (but now the reason thereof is explained).

Note that the set of tests marked CORE actually failed on Windows, but no one noticed because of a bug in our buildspec. PR to address this to follow.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 827d536).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/95528351

@tautschnig tautschnig changed the title Move regression tests of the C front-end to a suitable folder [blocks: #2310] Move regression tests of the C front-end to a suitable folder [blocks: #2310, #3627] Dec 28, 2018
There is no bounded model checking expected or required by these tests, and also
they use GCC-specific built-ins. There is still work left to be done, so most
remain KNOWNBUG (but now the reason thereof is explained).
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 25de48d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96030402

@tautschnig tautschnig merged commit ea8d1cf into diffblue:develop Jan 2, 2019
@tautschnig tautschnig deleted the vs-move-tests branch January 2, 2019 11:10
tautschnig added a commit that referenced this pull request Jan 2, 2019
Make Powershell stop on errors [depends-on: #3616, blocks: #2310, #3636, #3637]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants