Skip to content

Conversation

@tautschnig
Copy link
Collaborator

The regression test was only compatible with non-Windows systems. (Tests fail on Windows, but this wasn't noticed due Powershell not aborting on failing commands.)

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The regression test was only compatible with non-Windows systems.
@tautschnig tautschnig changed the title Windows/64bit uses signed long long as index type Windows/64bit uses signed long long as index type [blocks: #2310, #3627] Dec 28, 2018
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 6ae9f93).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/95900698

@kroening kroening merged commit 71ca96a into diffblue:develop Dec 28, 2018
@tautschnig tautschnig deleted the vs-long-long branch December 28, 2018 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants