Do not use global variable that requires an initializer function [depends-on: #3627] #3645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tautschnig
commented
Dec 29, 2018
tautschnig
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
tautschnig
requested review from
NathanJPhillips,
cesaro,
chrisr-diffblue,
cristina-david,
kroening,
peterschrammel,
pkesseli,
smowton and
thk123
as code owners
allredj
reviewed
Dec 29, 2018
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 78d138d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/95939600
We had failing regression tests, but this went unnoticed because the goto-cl regression tests were successful (which were the last common run in the cmdlet).
In particular don't use one that depends on other globals to be initialized first.
tautschnig
force-pushed
the
vs-fix-global
branch
from
78d138d to
3ef168a
Compare
allredj
reviewed
Jan 2, 2019
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 3ef168a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96062648
smowton
approved these changes
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.