byte_extract lowering of unions [blocks: #2068] #4187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue,
kroening,
peterschrammel and
smowton
as code owners
smowton
approved these changes
Feb 14, 2019
allredj
reviewed
Feb 14, 2019
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 19b8b80).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100912495
Refactor the code used for arrays to make it re-usable for vectors and arrays.
We already limited extraction at an uppper bound, but when we know the offset we can also start as late as possible. For structs, for example, we now do not expand components that will be irrelevant to the final result.
No need to construct index_exprt when we can just pick the operand out of a vector.
This makes the unit of measurement explicit and thus should help avoid bits/bytes confusion.
This makes the interface much more explicit about what is or isn't supported at moment.
We previously handled unions like PODs.
tautschnig
force-pushed
the
byte-op-union
branch
from
19b8b80 to
761ad8a
Compare
tautschnig
changed the title
allredj
reviewed
Feb 14, 2019
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 761ad8a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100979304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously handled unions like PODs.
Only the last commit is new, the rest is borrowed from #4124.