Skip to content

Conversation

@kroening
Copy link
Collaborator

@kroening kroening commented Nov 8, 2019

This will enable removing those deprecated constructors.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This will enable removing those deprecated constructors.
@kroening kroening marked this pull request as ready for review November 8, 2019 15:18
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 04f73fb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/135683588

@kroening kroening merged commit 87c3a39 into develop Nov 22, 2019
@kroening kroening deleted the unit-deprecated branch November 22, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants