Skip to content

multiple --unwindset options #5186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kroening merged 1 commit into from
Nov 16, 2019
Merged

multiple --unwindset options #5186

kroening merged 1 commit into from
Nov 16, 2019

Conversation

@kroening
Copy link
Collaborator

@kroening kroening commented Nov 14, 2019 •
edited
Loading

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening force-pushed the multi-unwindset branch 2 times, most recently from 7c3e6d3 to 2557060 Compare November 14, 2019 11:16
@kroening
Copy link
Collaborator Author

kroening commented Nov 14, 2019

A future PR may move the parsing of the comma-separated sequence closer to the front-end.

allredj
allredj reviewed Nov 14, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 2557060).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/136520511

@kroening kroening marked this pull request as ready for review November 14, 2019 17:09
@kroening kroening mentioned this pull request Nov 14, 2019
Closed
peterschrammel
peterschrammel reviewed Nov 14, 2019
View reviewed changes
allredj
allredj reviewed Nov 15, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 42a3ed2).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/136761692

@kroening kroening assigned peterschrammel and danielsn and unassigned kroening Nov 15, 2019
@peterschrammel peterschrammel removed their assignment Nov 15, 2019
@kroening kroening merged commit 7f07693 into develop Nov 16, 2019
@karkhaz
Copy link
Collaborator

karkhaz commented Jan 29, 2020

This PR fixes #5185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterschrammel peterschrammel peterschrammel approved these changes

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@danpoe danpoe Awaiting requested review from danpoe

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue Awaiting requested review from hannes-steffenhagen-diffblue

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@smowton smowton Awaiting requested review from smowton

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

+1 more reviewer

@allredj allredj allredj left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@danielsn danielsn

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kroening @karkhaz @peterschrammel @allredj @danielsn