Skip to content

Misc string cleanup #5232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thk123 merged 3 commits into from
Feb 21, 2020
Merged

Misc string cleanup #5232

thk123 merged 3 commits into from
Feb 21, 2020

Conversation

@thk123
Copy link
Contributor

@thk123 thk123 commented Feb 12, 2020 •
edited
Loading

Just some trivial tidy up whilst looking at the code.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [na] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • [na] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [na] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

thk123 added 2 commits February 18, 2020 10:14
Update parameter names
edc76d1 
These did not match their implementation names
Correct function_id comment
51d792b 
The variable is used in the declaration of a variable. So there is no
need to have the dud usage to suppress warnings about unused variables.
Updated comment saying it was unused as well.
@thk123 thk123 force-pushed the misc-string-cleanup branch from e137726 to c911598 Compare February 18, 2020 11:08
hannes-steffenhagen-diffblue
hannes-steffenhagen-diffblue reviewed Feb 18, 2020
View reviewed changes
jbmc/src/java_bytecode/java_string_library_preprocess.cpp Outdated
{
// Code for the output
code_blockt code;
code_blockt output_code;
Copy link
Contributor

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ Even better, copy_constructor_body.

Rename variable to self explantory name
786f896 
Makes clear it is what the function produces, and makes the comment
explaining it redundant.
@thk123 thk123 force-pushed the misc-string-cleanup branch from c911598 to 786f896 Compare February 20, 2020 13:27
@thk123 thk123 marked this pull request as ready for review February 20, 2020 13:27
@thk123
Copy link
Contributor Author

thk123 commented Feb 21, 2020

@smowton would you mind having a look at this (very short) PR as need code owner.

@thk123 thk123 merged commit aa5dac2 into diffblue:develop Feb 21, 2020
@thk123 thk123 deleted the misc-string-cleanup branch February 21, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kroening kroening kroening approved these changes

@cesaro cesaro Awaiting requested review from cesaro

@cristina-david cristina-david Awaiting requested review from cristina-david

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

+2 more reviewers

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue left review comments

@smowton smowton smowton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thk123 @smowton @kroening @hannes-steffenhagen-diffblue