Skip to content

Conversation

@thk123
Copy link
Contributor

@thk123 thk123 commented Apr 2, 2020

The cmake code build job has never succeeded. Originally to do with permissions, current failure appears to be because cmake isn't installed.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [na] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • [na] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [na] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@thk123
Copy link
Contributor Author

thk123 commented Apr 2, 2020

This causes the cbmc-linux-cmake-gcc build pass: https://us-east-1.console.aws.amazon.com/codesuite/codebuild/projects/cbmc-linux-cmake-gcc/build/cbmc-linux-cmake-gcc%3A484b61f7-3be1-421e-8ec1-d4da4e01938f/log?region=us-east-1

Not sure why the status isn't reported back here. Also I had to manually trigger it. I've asked @peterschrammel to see if something needs configuring still on the AWS side.

@hannes-steffenhagen-diffblue
Copy link
Contributor

I'd hold off on merging it until we're sure the job actually runs now.

This is a dependency.
@thk123 thk123 force-pushed the fix-cmake-codebuild branch from 6e04bd8 to fe2d6e1 Compare April 2, 2020 12:36
@thk123
Copy link
Contributor Author

thk123 commented Apr 2, 2020

@hannes-steffenhagen-diffblue Peter said he'd fixed it - I've force pushed so hopefully will trigger it this time.

@thk123 thk123 mentioned this pull request Apr 2, 2020
5 tasks
@thk123 thk123 merged commit 641a14e into diffblue:develop Apr 2, 2020
@thk123 thk123 deleted the fix-cmake-codebuild branch April 2, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants