Skip to content

Conversation

@tautschnig
Copy link
Collaborator

In 375e9a8 the construction of zero initialisers was switched to
array_of expressions for arrays with more than 1000 elements. This is
beneficial to avoid running out of memory, but didn't take into account
arrays with designated initialisers, which this patch fixes.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

In 375e9a8 the construction of zero initialisers was switched to
array_of expressions for arrays with more than 1000 elements. This is
beneficial to avoid running out of memory, but didn't take into account
arrays with designated initialisers, which this patch fixes.
@kroening
Copy link
Collaborator

Now tempted to always use the array_of, even for small arrays!

@tautschnig tautschnig merged commit 240a30a into diffblue:develop Apr 18, 2020
@tautschnig tautschnig deleted the large-array-fix branch April 18, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants