Fix depth_iterator_baset move assignment to return a value. #5312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markrtuttle
requested review from
kroening,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
smowton
approved these changes
Apr 21, 2020
Contributor
smowton
left a comment
smowton
left a comment
There was a problem hiding this comment.
Pretty amazed this ever compiled anywhere!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the depth_iterator_baset assignment operator return a value.
The type says it should return a value, and VS2019 fails to builds without a return value.