Make min unwind consistent with unwind #5334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thk123
requested review from
chrisr-diffblue,
kroening,
smowton and
tautschnig
as code owners
thk123
commented
May 6, 2020
regression/cbmc-incr-oneloop/ignore-before-unwind/include_first_unwind0.desc
Show resolved
Hide resolved
regression/cbmc-incr-oneloop/ignore-before-unwind/include_first_unwind0.desc
Show resolved
Hide resolved
|
|
||
| #include <util/source_location.h> | ||
| #include <util/xml.h> | ||
| #include <iostream> |
src/goto-checker/bmc_util.h
Outdated
| " but before solving that iteration. If for \n" \ | ||
| " example it is 1, then the loop will be \n" \ | ||
| " unwound once, and immediately checked. \n" \ | ||
| " Note: this means min-unwind 1 or \n"\ |
Member
There was a problem hiding this comment.
Suggested change
| " Note: this means min-unwind 1 or \n"\ | |
| " Note: this means for min-unwind 1 or \n"\ |
?
added 2 commits
May 6, 2020 14:02
It is agreed that if --unwind N can find an error, that unwind-min N should find the same error. That is, we start checking immediately after doing N unwinds, rather than after doing N increments of the incremental unwinding (i.e. unwind + solve)
thk123
force-pushed
the
make-min-unwind-consistent-with-unwind
branch
2 times, most recently
from
565ee5c to
50bdc60
Compare
It was somewhat ambiguous whether the checking started after N unwinds, or after N incremental solves. This documentation clarifies the checking is enabled after the Nth unwind, before the Nth solve.
thk123
force-pushed
the
make-min-unwind-consistent-with-unwind
branch
from
50bdc60 to
293d469
Compare
Contributor
Author
|
@peterschrammel ready for rereview |
peterschrammel
approved these changes
May 6, 2020
NlightNFotis
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally there should be documentation for the incremental feature in the docs, but it doesn't seem to be present. @peterschrammel are you aware of any that can be imported in?