Skip to content

Do not add pointer primitive check for cprover internals #5336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danpoe merged 1 commit into from
May 13, 2020
Merged

Do not add pointer primitive check for cprover internals #5336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/analyses/goto_check.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Author: Daniel Kroening, kroening@kroening.com
#include <util/options.h>
#include <util/pointer_offset_size.h>
#include <util/pointer_predicates.h>
#include <util/prefix.h>
#include <util/simplify_expr.h>
#include <util/std_expr.h>
#include <util/std_types.h>
Expand Down Expand Up @@ -1187,12 +1188,23 @@ void goto_checkt::pointer_primitive_check(
if(!enable_pointer_primitive_check)
return;

if(expr.source_location().is_built_in())
return;

const exprt pointer = (expr.id() == ID_r_ok || expr.id() == ID_w_ok)
? to_binary_expr(expr).lhs()
: to_unary_expr(expr).op();

CHECK_RETURN(pointer.type().id() == ID_pointer);

if(pointer.id() == ID_symbol)
{
const auto &symbol_expr = to_symbol_expr(pointer);

if(has_prefix(id2string(symbol_expr.get_identifier()), CPROVER_PREFIX))
return;
}

const auto size_of_expr_opt = size_of_expr(pointer.type().subtype(), ns);

const exprt size = !size_of_expr_opt.has_value()
Expand Down