Fix bug where reference to temporary string was returned

[hannes-steffenhagen-diffblue]

This is fortunately only in a unit tests and apparently hasn’t caused any
problems so far, but we nevertheless should avoid returning references to
temporaries.

As a bonus the fixed code is simpler.

• Each commit message has a non-empty body, explaining why the change was made.
• Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[martin-cs]

Yep; that definitely needs fixing.