Skip to content

Conversation

@tautschnig
Copy link
Collaborator

The file relies on irep.h providing std::map, which it does not do if
setting NAMED_SUB_IS_FORWARD_LIST.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The file relies on irep.h providing std::map, which it does not do if
setting NAMED_SUB_IS_FORWARD_LIST.
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #5556 (2732bdb) into develop (27f2a8a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5556   +/-   ##
========================================
  Coverage    68.53%   68.53%           
========================================
  Files         1187     1187           
  Lines        98263    98263           
========================================
  Hits         67347    67347           
  Misses       30916    30916           
Flag Coverage Δ
cproversmt2 43.09% <ø> (ø)
regression 65.71% <ø> (ø)
unit 32.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/util/irep_hash_container.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f2a8a...2732bdb. Read the comment docs.

@kroening kroening merged commit 9ed3fb7 into diffblue:develop Nov 11, 2020
@tautschnig tautschnig deleted the fix-missing-include branch November 11, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants