Skip to content

Conversation

@tautschnig
Copy link
Collaborator

The constants are no longer stored as string literals, and instead use
the bitvector representation (currently: hexadecimal values).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #5611 (ecd5aff) into develop (e23bf5c) will increase coverage by 0.01%.
The diff coverage is 62.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5611      +/-   ##
===========================================
+ Coverage    69.45%   69.47%   +0.01%     
===========================================
  Files         1243     1243              
  Lines       100614   100615       +1     
===========================================
+ Hits         69886    69905      +19     
+ Misses       30728    30710      -18     
Flag Coverage Δ
cproversmt2 43.13% <12.50%> (-0.01%) ⬇️
regression 66.36% <62.50%> (+0.01%) ⬆️
unit 32.28% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ansi-c/expr2c.cpp 69.25% <62.50%> (-0.27%) ⬇️
src/goto-instrument/goto_program2code.cpp 67.91% <0.00%> (+0.38%) ⬆️
src/goto-instrument/dump_c.cpp 78.42% <0.00%> (+3.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23bf5c...ecd5aff. Read the comment docs.

@tautschnig tautschnig force-pushed the enum-dump-c branch 2 times, most recently from 857fa8a to 81672ae Compare November 25, 2020 11:36
The constants are no longer stored as string literals, and instead use
the bitvector representation (currently: hexadecimal values).

Also make regression tests print the dump-c generated C code in
regression tests.
We need to lookup by encoded value, not the decoded integer value.
@kroening kroening merged commit 837da38 into diffblue:develop Dec 23, 2020
@tautschnig tautschnig deleted the enum-dump-c branch December 23, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants