goto_cc_modet isn't a messaget #5618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue and
kroening
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5618 +/- ##
===========================================
- Coverage 69.32% 69.32% -0.01%
===========================================
Files 1241 1241
Lines 100443 100450 +7
===========================================
+ Hits 69636 69638 +2
- Misses 30807 30812 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Use local messaget instances instead as there is no is-a relationship between goto_cc_modet (nor any class deriving from it) and messaget.
tautschnig
force-pushed
the
messaget-goto_cc_mode
branch
from
6281309 to
d40c7e2
Compare
martin-cs
approved these changes
Nov 19, 2020
kroening
reviewed
Nov 28, 2020
| eval_verbosity( | ||
| messaget::eval_verbosity( | ||
| cmdline.get_value("verbosity"), messaget::M_ERROR, gcc_message_handler); | ||
|
|
kroening
reviewed
Nov 28, 2020
| eval_verbosity( | ||
| messaget::eval_verbosity( | ||
| cmdline.get_value("verbosity"), messaget::M_ERROR, message_handler); | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
I had wondered as well, but yes, it does: the message_handler argument will have its verbosity set. We might want to change this interface though as that makes two people who were surprised by this code...
kroening
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use local messaget instances instead as there is no is-a relationship
between goto_cc_modet (nor any class deriving from it) and messaget.