Skip to content

Conversation

@tautschnig
Copy link
Collaborator

validate_type is not actually used (anymore), instead static member
functions check are used.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #5658 (71af819) into develop (f85b11d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5658   +/-   ##
========================================
  Coverage    69.41%   69.42%           
========================================
  Files         1243     1243           
  Lines       100621   100627    +6     
========================================
+ Hits         69850    69856    +6     
  Misses       30771    30771           
Flag Coverage Δ
cproversmt2 43.14% <0.00%> (-0.01%) ⬇️
regression 66.31% <100.00%> (+<0.01%) ⬆️
unit 32.27% <57.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/util/std_types.h 94.46% <100.00%> (+0.06%) ⬆️
src/util/validate_types.cpp 88.46% <100.00%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f85b11d...71af819. Read the comment docs.

@tautschnig tautschnig self-assigned this Dec 14, 2020
validate_type is not actually used (anymore), instead static member
functions `check` are used.
@tautschnig tautschnig merged commit c9c3ca6 into diffblue:develop Dec 14, 2020
@tautschnig tautschnig deleted the validation-cleanup branch December 14, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants