Skip to content

Conversation

@tautschnig
Copy link
Collaborator

The documentation states that it does not generate any code other than
0. Hence, don't maintain a library function, but instead discard the
expression in the type checker.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The documentation states that it does not generate any code other than
`0`. Hence, don't maintain a library function, but instead discard the
expression in the type checker.
@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #5685 (42e1431) into develop (4c3a0a6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5685   +/-   ##
========================================
  Coverage    69.48%   69.49%           
========================================
  Files         1243     1243           
  Lines       100676   100674    -2     
========================================
+ Hits         69956    69962    +6     
+ Misses       30720    30712    -8     
Flag Coverage Δ
cproversmt2 43.11% <100.00%> (+<0.01%) ⬆️
regression 66.38% <100.00%> (+<0.01%) ⬆️
unit 32.26% <20.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ansi-c/ansi_c_internal_additions.cpp 94.02% <ø> (ø)
src/goto-programs/goto_clean_expr.cpp 99.29% <ø> (-0.03%) ⬇️
src/goto-programs/goto_convert_function_call.cpp 55.26% <ø> (-2.24%) ⬇️
src/ansi-c/c_typecheck_expr.cpp 75.92% <100.00%> (+0.60%) ⬆️
src/ansi-c/c_preprocess.cpp 32.98% <0.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c3a0a6...42e1431. Read the comment docs.

@kroening kroening merged commit 95097a8 into diffblue:develop Dec 23, 2020
@tautschnig tautschnig deleted the noop branch December 23, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants