Skip to content

Conversation

@tautschnig
Copy link
Collaborator

Make the "clean" configuration produce integers and raw types instead as neither enum values or typedef names make sense without their declarations, which aren't present in GraphML output.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Make the "clean" configuration produce integers instead.
@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #5687 (33206c1) into develop (95097a8) will increase coverage by 0.00%.
The diff coverage is 90.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5687   +/-   ##
========================================
  Coverage    69.49%   69.49%           
========================================
  Files         1243     1243           
  Lines       100674   100676    +2     
========================================
+ Hits         69962    69967    +5     
+ Misses       30712    30709    -3     
Flag Coverage Δ
cproversmt2 43.14% <90.00%> (+0.03%) ⬆️
regression 66.38% <90.00%> (+<0.01%) ⬆️
unit 32.26% <20.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ansi-c/expr2c.cpp 69.50% <88.88%> (+0.25%) ⬆️
src/ansi-c/expr2c.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95097a8...33206c1. Read the comment docs.

@kroening kroening assigned tautschnig and unassigned kroening Dec 23, 2020
typedefs are not meaningful when taken out of context.
@tautschnig tautschnig merged commit 4ee2683 into diffblue:develop Dec 24, 2020
@tautschnig tautschnig deleted the graphml-enum branch December 24, 2020 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants