use a hash table in the expression formatter #5817
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5817 +/- ##
========================================
Coverage 72.88% 72.88%
========================================
Files 1421 1421
Lines 154217 154269 +52
========================================
+ Hits 112395 112441 +46
- Misses 41822 41828 +6
Continue to review full report at Codecov.
|
kroening
requested review from
peterschrammel,
smowton and
tautschnig
as code owners
| expr_mapt expr_map; | ||
|
|
||
| /// find the formatter for a given expression | ||
| const formattert &find_formatter(const exprt &); |
There was a problem hiding this comment.
Shouldn't this be const?
There was a problem hiding this comment.
As-is now yes, but was contemplating to generate formatters on the fly.
|
|
||
| private: | ||
| /// setup the expressions we can format | ||
| void setup(); |
There was a problem hiding this comment.
Possibly a matter of taste: Is there value in having this extra method as opposed to just doing all work directly in the constructor?
There was a problem hiding this comment.
Not a whole lot, it may convey a bit of information to the reader.
This replaces the linear-time if-then-else construct by a logarithmic hash table. The hash table could be extended at runtime.
kroening
force-pushed
the
format_expr_configt
branch
from
efd4697 to
3724dea
Compare
This replaces the linear-time if-then-else construct by a logarithmic hash
table. The hash table could be extended at runtime.