Skip to content

Conversation

@tautschnig
Copy link
Collaborator

Invoking it for arbitrary binary comparisons resulted in an invariant
failure.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Invoking it for arbitrary binary comparisons resulted in an invariant
failure.
@tautschnig tautschnig self-assigned this May 24, 2021
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #6142 (b1fcc9a) into develop (918e17c) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6142      +/-   ##
===========================================
- Coverage    74.98%   74.95%   -0.04%     
===========================================
  Files         1447     1447              
  Lines       158212   158208       -4     
===========================================
- Hits        118633   118577      -56     
- Misses       39579    39631      +52     
Impacted Files Coverage Δ
src/solvers/flattening/bv_pointers.cpp 81.15% <100.00%> (-0.24%) ⬇️
src/solvers/flattening/bv_pointers.h 100.00% <100.00%> (ø)
src/util/simplify_expr_int.cpp 82.30% <100.00%> (-1.71%) ⬇️
src/goto-programs/link_goto_model.cpp 0.00% <0.00%> (-77.97%) ⬇️
src/goto-programs/goto_program.cpp 53.05% <0.00%> (-13.62%) ⬇️
src/util/simplify_expr_pointer.cpp 80.99% <0.00%> (-4.68%) ⬇️
src/util/find_symbols.cpp 82.22% <0.00%> (-3.34%) ⬇️
src/util/json_irep.cpp 92.85% <0.00%> (-1.79%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53564c1...b1fcc9a. Read the comment docs.

@tautschnig tautschnig merged commit 4880335 into diffblue:develop May 24, 2021
@tautschnig tautschnig deleted the pointer-comparison-simplify branch May 24, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants