Skip to content

Conversation

@martin-cs
Copy link
Collaborator

This means that the core tests will run cleanly without z3 on the path.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This means that the core tests will run cleanly without z3 on the path.
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #6181 (7486222) into develop (0002950) will increase coverage by 7.84%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6181      +/-   ##
===========================================
+ Coverage    67.40%   75.25%   +7.84%     
===========================================
  Files         1157     1454     +297     
  Lines        95236   160796   +65560     
===========================================
+ Hits         64197   121006   +56809     
- Misses       31039    39790    +8751     
Flag Coverage Δ
cproversmt2 ?
regression ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/util/string_container.cpp 52.94% <0.00%> (-47.06%) ⬇️
src/ansi-c/gcc_types.cpp 41.86% <0.00%> (-46.38%) ⬇️
src/solvers/prop/prop.cpp 42.85% <0.00%> (-41.76%) ⬇️
src/solvers/flattening/boolbv_member.cpp 53.65% <0.00%> (-38.65%) ⬇️
src/cpp/cpp_storage_spec.cpp 65.00% <0.00%> (-35.00%) ⬇️
src/util/cmdline.h 66.66% <0.00%> (-33.34%) ⬇️
src/solvers/strings/array_pool.h 66.66% <0.00%> (-33.34%) ⬇️
src/solvers/strings/string_refinement.h 66.66% <0.00%> (-33.34%) ⬇️
...rs/strings/string_concatenation_builtin_function.h 0.00% <0.00%> (-33.34%) ⬇️
src/ansi-c/c_typecheck_base.cpp 50.54% <0.00%> (-30.35%) ⬇️
... and 1433 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f847fcd...7486222. Read the comment docs.

@martin-cs martin-cs requested a review from SaswatPadhi June 15, 2021 19:41
@martin-cs
Copy link
Collaborator Author

The code coverage results appear to be way off.

Copy link
Contributor

@SaswatPadhi SaswatPadhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Thanks for fixing this.

@martin-cs martin-cs merged commit dfe252f into diffblue:develop Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants