VSD - correct widening merge to handle extreme values #6190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If new upper bound is already at maximum, or overflows, then explicitly set to max_exprt(type)
If new lower bound is already at minimum, or underflows, then explicitly set to min_exprt(type)
Codecov Report
@@ Coverage Diff @@
## develop #6190 +/- ##
===========================================
- Coverage 75.62% 75.17% -0.46%
===========================================
Files 1454 1456 +2
Lines 160922 161078 +156
===========================================
- Hits 121705 121088 -617
- Misses 39217 39990 +773
Continue to review full report at Codecov.
|
Means widened ranges are calculated in the same way for both intervals and value sets, both now handling max & min appropriately.
jezhiggins
force-pushed
the
vsd/widen-to-extreme
branch
from
0f589f4 to
5cd42eb
Compare
jezhiggins
requested review from
chrisr-diffblue,
martin-cs and
peterschrammel
as code owners
martin-cs
approved these changes
Jun 20, 2021
Collaborator
|
Only failure is from the code coverage and TBH I am suspicious of the numbers it reports. The patch is listed as having 100% coverage so I am going to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a widening merge, it is possible for the upper or lower bound to be extended to integer limits -
max_exprt(type)ormin_exprt(type). This was not handled gracefully and could have resulted in an (inappropriate) invariant violation constructing new intervals. Extreme values, along with overflow and underflow calculating new bounds, are now handled appropriately.