Skip to content

Conversation

@thomasspriggs
Copy link
Contributor

This PR adds data structures for setting different smt2 logics in incremental solving. Raised in response to this comment chain on my preceding PR - #6240 (comment)

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #6254 (ccfbaee) into develop (5dd2519) will decrease coverage by 0.03%.
The diff coverage is 58.78%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6254      +/-   ##
===========================================
- Coverage    76.22%   76.18%   -0.04%     
===========================================
  Files         1482     1484       +2     
  Lines       161866   162092     +226     
===========================================
+ Hits        123383   123495     +112     
- Misses       38483    38597     +114     
Impacted Files Coverage Δ
src/solvers/flattening/boolbv.h 76.19% <ø> (ø)
src/solvers/smt2_incremental/smt_logics.cpp 30.00% <ø> (-11.67%) ⬇️
src/solvers/smt2_incremental/smt_logics.h 100.00% <ø> (ø)
...rc/solvers/smt2_incremental/smt_to_smt2_string.cpp 92.37% <ø> (-0.13%) ⬇️
unit/util/piped_process.cpp 28.57% <28.57%> (ø)
src/util/piped_process.cpp 75.00% <75.00%> (ø)
src/ansi-c/parser.y 79.26% <87.50%> (ø)
src/goto-instrument/contracts/contracts.cpp 91.93% <88.67%> (ø)
src/ansi-c/c_typecheck_code.cpp 78.43% <100.00%> (ø)
src/solvers/smt2_incremental/smt_logics.def 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7601ad5...ccfbaee. Read the comment docs.

Because no customisation expected for these classes, using the `.def` to
implement them saves duplicating code.
So that additional logics can be added based solely on updating the
`.def` file.
We almost certainly don't need all of these in the near future, but
having the data structures for them available will make it straight
forward to experiment with different options.
@thomasspriggs thomasspriggs force-pushed the tas/smt2_more_logics branch from c9cec84 to ccfbaee Compare July 26, 2021 20:18
@thomasspriggs thomasspriggs merged commit 9e3edf7 into diffblue:develop Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants