Skip to content

Conversation

@kroening
Copy link
Collaborator

@kroening kroening commented Aug 8, 2021

This completes the new API of goto_programt::instructiont by introducing methods for accessing the properties of function calls.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #6281 (41e54d7) into develop (19947e9) will decrease coverage by 0.00%.
The diff coverage is 78.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6281      +/-   ##
===========================================
- Coverage    75.90%   75.90%   -0.01%     
===========================================
  Files         1492     1492              
  Lines       162712   162705       -7     
===========================================
- Hits        123509   123503       -6     
+ Misses       39203    39202       -1     
Impacted Files Coverage Δ
src/goto-instrument/contracts/contracts.cpp 92.59% <ø> (ø)
src/goto-programs/goto_program.cpp 68.48% <53.84%> (+0.08%) ⬆️
src/goto-programs/parameter_assignments.cpp 71.42% <60.00%> (-0.80%) ⬇️
src/goto-programs/goto_program.h 89.41% <66.66%> (-1.28%) ⬇️
src/goto-programs/interpreter.cpp 51.45% <72.72%> (+0.08%) ⬆️
src/analyses/constant_propagator.cpp 95.06% <85.71%> (+0.85%) ⬆️
src/goto-programs/cfg.h 85.36% <100.00%> (ø)
src/goto-programs/goto_inline_class.cpp 87.17% <100.00%> (-0.04%) ⬇️
src/goto-programs/instrument_preconditions.cpp 91.66% <100.00%> (ø)
...oto-programs/label_function_pointer_call_sites.cpp 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61fd24d...41e54d7. Read the comment docs.

@kroening kroening marked this pull request as ready for review August 9, 2021 06:43
This completes the new API of goto_programt::instructiont by introducing
methods for accessing the properties of function calls.
@kroening kroening force-pushed the goto_instruction_function_call branch from 0917ddb to 41e54d7 Compare August 9, 2021 08:27
@kroening kroening merged commit b829c54 into develop Aug 9, 2021
@kroening kroening deleted the goto_instruction_function_call branch August 9, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants