Skip to content

Conversation

@kroening
Copy link
Collaborator

Basically all frontends are using code_assignt, which is meant to be used in
goto program instructions only. This commit separates out the two uses.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #6389 (998b163) into develop (af94148) will increase coverage by 0.00%.
The diff coverage is 86.02%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6389   +/-   ##
========================================
  Coverage    75.97%   75.98%           
========================================
  Files         1523     1523           
  Lines       164191   164221   +30     
========================================
+ Hits        124748   124780   +32     
+ Misses       39443    39441    -2     
Impacted Files Coverage Δ
src/ansi-c/expr2c_class.h 100.00% <ø> (ø)
src/cpp/cpp_typecheck_initializer.cpp 29.26% <0.00%> (ø)
src/goto-instrument/dot.cpp 0.00% <0.00%> (ø)
src/goto-programs/goto_program.h 90.49% <ø> (+0.21%) ⬆️
src/util/allocate_objects.h 100.00% <ø> (ø)
jbmc/src/java_bytecode/code_with_references.cpp 82.35% <33.33%> (ø)
src/goto-symex/symex_main.cpp 86.00% <60.00%> (+0.03%) ⬆️
src/util/allocate_objects.cpp 90.90% <62.50%> (ø)
jbmc/src/java_bytecode/java_entry_point.cpp 89.35% <66.66%> (+0.28%) ⬆️
...rc/ansi-c/c_typecheck_gcc_polymorphic_builtins.cpp 76.58% <75.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038a53b...998b163. Read the comment docs.

@kroening kroening marked this pull request as ready for review October 12, 2021 11:39
Basically all frontends are using code_assignt, which is meant to be used in
goto program instructions only.  This commit separates out the two uses.
@kroening kroening force-pushed the code_frontend_assign branch from 4702c3e to 998b163 Compare October 19, 2021 14:53
@tautschnig tautschnig merged commit 0805702 into develop Oct 20, 2021
@tautschnig tautschnig deleted the code_frontend_assign branch October 20, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants