Skip to content

Conversation

@kroening
Copy link
Collaborator

This moves allocate_objects.h/.cpp to goto-programs, since it relates to
procedural code.

nondet.h/.cpp are moved to jbmc, which is where it is used.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This moves allocate_objects.h/.cpp to goto-programs, since it relates to
procedural code.

nondet.h/.cpp are moved to jbmc, which is where it is used.
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #6410 (cab7f30) into develop (3d64049) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6410   +/-   ##
========================================
  Coverage    75.98%   75.98%           
========================================
  Files         1523     1523           
  Lines       164284   164284           
========================================
  Hits        124839   124839           
  Misses       39445    39445           
Impacted Files Coverage Δ
jbmc/src/java_bytecode/assignments_from_json.cpp 97.26% <ø> (ø)
jbmc/src/java_bytecode/java_entry_point.cpp 89.35% <ø> (ø)
jbmc/src/java_bytecode/java_object_factory.cpp 94.33% <ø> (ø)
...c/java_bytecode/java_string_library_preprocess.cpp 97.43% <ø> (ø)
jbmc/src/java_bytecode/nondet.cpp 98.03% <ø> (ø)
src/ansi-c/c_nondet_symbol_factory.cpp 100.00% <ø> (ø)
src/ansi-c/c_nondet_symbol_factory.h 100.00% <ø> (ø)
...c/goto-harness/function_call_harness_generator.cpp 79.60% <ø> (ø)
src/goto-programs/allocate_objects.cpp 90.90% <ø> (ø)
src/goto-programs/allocate_objects.h 100.00% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29ca8a9...cab7f30. Read the comment docs.

@kroening kroening merged commit cd93b5d into develop Oct 21, 2021
@kroening kroening deleted the move_nondet_h branch October 21, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants