Skip to content

Conversation

@tautschnig
Copy link
Collaborator

A function of this name was defined in two places, and all uses can
safely be replaced by skip_typecast.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

A function of this name was defined in two places, and all uses can
safely be replaced by skip_typecast.
@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #6544 (51c133c) into develop (6642254) will decrease coverage by 0.00%.
The diff coverage is 93.65%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6544      +/-   ##
===========================================
- Coverage    75.99%   75.98%   -0.01%     
===========================================
  Files         1578     1578              
  Lines       180944   181029      +85     
===========================================
+ Hits        137500   137548      +48     
- Misses       43444    43481      +37     
Impacted Files Coverage Δ
src/goto-instrument/contracts/assigns.h 100.00% <ø> (ø)
src/goto-instrument/contracts/contracts.h 100.00% <ø> (ø)
src/goto-instrument/contracts/utils.cpp 89.47% <78.57%> (-4.56%) ⬇️
src/goto-instrument/contracts/assigns.cpp 95.83% <90.00%> (-0.60%) ⬇️
src/goto-instrument/contracts/contracts.cpp 91.13% <98.46%> (-3.99%) ⬇️
jbmc/src/java_bytecode/java_pointer_casts.cpp 92.50% <100.00%> (-0.84%) ⬇️
...s/variable-sensitivity/interval_abstract_value.cpp 84.61% <100.00%> (-0.28%) ⬇️
src/goto-instrument/contracts/utils.h 100.00% <100.00%> (ø)
src/analyses/dirty.h 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d8c91...51c133c. Read the comment docs.

@tautschnig tautschnig merged commit 27b02b3 into diffblue:develop Jan 10, 2022
@tautschnig tautschnig deleted the remove-look_through_casts branch January 10, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants