Skip to content

Use random_shuffle in a future-proof way #6758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kroening merged 1 commit into from
Mar 24, 2022
Merged

Use random_shuffle in a future-proof way #6758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions unit/util/interval/get_extreme.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
Author: DiffBlue Limited
\*******************************************************************/

#include <testing-utils/use_catch.h>

#include <util/arith_tools.h>
#include <util/bitvector_types.h>
#include <util/interval.h>
Expand All @@ -13,6 +11,10 @@
#include <util/simplify_expr.h>
#include <util/symbol_table.h>

#include <testing-utils/use_catch.h>

#include <random>

#define V(X) (bvrep2integer(X.get(ID_value).c_str(), 32, true))
#define V_(X) (bvrep2integer(X.c_str(), 32, true))
#define CEV(X) (from_integer(mp_integer(X), signedbv_typet(32)))
Expand Down Expand Up @@ -147,7 +149,9 @@ SCENARIO("get extreme exprt value", "[core][analyses][interval][get_extreme]")

WHEN("All from [-100:100] are shuffled and selected")
{
std::random_shuffle(ve.begin(), ve.end());
std::random_device rd;
std::mt19937 g(rd());
std::shuffle(ve.begin(), ve.end(), g);

exprt min = constant_interval_exprt::get_extreme(ve, true);
exprt max = constant_interval_exprt::get_extreme(ve, false);
Expand Down