Support _Complex in the C++ front-end #6868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We typecheck this via the same code path as the C front-end, and just need to accept that this type exists. Clang-14 uses _Complex in system headers, and moving to Ubuntu 22.04 GitHub runners requires fixing this first.
kroening
reviewed
May 19, 2022
| type.id() == ID_constructor || type.id() == ID_destructor || type.id() == ID_c_enum) | ||
| { | ||
| } | ||
| else if(type.id()==ID_c_enum) |
Collaborator
There was a problem hiding this comment.
This change seems unrelated to _Complex?
Collaborator
Author
There was a problem hiding this comment.
Indeed, see the last sentence of the commit message in the second commit. It's drive-by cleanup while debugging to eventually make it possible to successfully pass the regression test that the second commit enables. (That regression test ensures we have coverage of the changes in the first commit.)
C typecheck_type performs its own conversion of raw type structures, and can't deal with those already done by the C++ front-end. Therefore, restored the "merged_type" before handing off to the C front-end. Also clean up unnecessary enum conversion steps, which later type checking stages actually take care of.
tautschnig
force-pushed
the
bugfixes/complex
branch
from
daf1c67 to
12354e4
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6868 +/- ##
========================================
Coverage 77.79% 77.80%
========================================
Files 1567 1567
Lines 179750 179756 +6
========================================
+ Hits 139844 139852 +8
+ Misses 39906 39904 -2
Continue to review full report at Codecov.
|
kroening
approved these changes
May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We typecheck this via the same code path as the C front-end, and just
need to accept that this type exists.
Clang-14 uses _Complex in system headers, and moving to Ubuntu 22.04
GitHub runners requires fixing this first.