SMT2 backend tweaks #6873
Merged
SMT2 backend tweaks #6873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kroening
commented
May 20, 2022
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
This adds a missing whitespace in the SMT2 output. The SMT2 formula parses correctly without the whitespace, so this is cosmetic.
This adds the missing conversion for "pointer - scalar" to the SMT2 backend. It's not used by CBMC, which rewrites these to p+(-s) in the simplifier.
This enables type2id in the SMT2 backend to convert struct_tag types.
Codecov Report
@@ Coverage Diff @@
## develop #6873 +/- ##
===========================================
- Coverage 77.79% 77.79% -0.01%
===========================================
Files 1567 1567
Lines 179750 179772 +22
===========================================
+ Hits 139844 139857 +13
- Misses 39906 39915 +9
Continue to review full report at Codecov.
|
kroening
requested review from
NlightNFotis,
TGWDB,
martin-cs,
peterschrammel and
thomasspriggs
as code owners
TGWDB
approved these changes
May 20, 2022
peterschrammel
approved these changes
May 20, 2022
Member
peterschrammel
left a comment
peterschrammel
left a comment
There was a problem hiding this comment.
Generally, it would be good to have tests that exercise these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.