Skip to content

Introduce typet::add_subtype #7110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kroening merged 4 commits into from
Sep 9, 2022
Merged

Introduce typet::add_subtype #7110

kroening merged 4 commits into from
Sep 9, 2022

Conversation

@kroening
Copy link
Collaborator

@kroening kroening commented Sep 8, 2022 •
edited
Loading

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Sep 8, 2022 •
edited
Loading

Codecov Report

Merging #7110 (8b7b7a9) into develop (e35425e) will increase coverage by 0.00%.
The diff coverage is 82.16%.

@@           Coverage Diff            @@
##           develop    #7110   +/-   ##
========================================
  Coverage    77.91%   77.92%           
========================================
  Files         1576     1576           
  Lines       181611   181645   +34     
========================================
+ Hits        141511   141541   +30     
- Misses       40100    40104    +4
Impacted Files Coverage Δ
src/cpp/cpp_declarator_converter.cpp 79.66% <0.00%> (ø)
src/cpp/cpp_typecheck_resolve.cpp 70.00% <0.00%> (ø)
src/cpp/template_map.cpp 57.85% <0.00%> (ø)
src/util/xml.cpp 73.88% <ø> (ø)
src/cpp/cpp_convert_type.cpp 72.72% <50.00%> (-0.69%) ⬇️
src/cpp/cpp_typecheck_code.cpp 80.41% <50.00%> (-0.26%) ⬇️
src/cpp/cpp_typecheck_type.cpp 75.75% <66.66%> (ø)
src/ansi-c/parser.y 80.47% <76.00%> (ø)
src/cpp/cpp_typecheck_conversions.cpp 84.95% <80.00%> (-0.05%) ⬇️
src/cpp/cpp_typecheck_enum_type.cpp 78.51% <83.33%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kroening
replace uses of typet::subtype() nonconst
040c93c 
This commit replaces uses of the nonconst typet::subtype() by casting the
type to the applicable subtype, and then using the appropriate accessor
method.
@kroening kroening marked this pull request as ready for review September 8, 2022 21:08
tautschnig
tautschnig approved these changes Sep 9, 2022
View reviewed changes
src/util/type.h
Comment on lines 66 to 71
public:
typet &add_subtype()
Copy link
Collaborator

@tautschnig tautschnig Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed out of band: it would be nice to have a comment that explains when (not) to use this.

Copy link
Collaborator Author

@kroening kroening Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@kroening
introduce typet::add_subtype()
d2c1f4b 
This introduces a new method typet::add_subtype(), identical in behavior to
typet::subtype() nonconst, to allow current users of this method to add a
subtype to a given type.  The name of the method reflects that the subtype
is added.
@kroening
use typet::add_subtype
61acf6c 
This commit replaces uses of typet::subtype() nonconst by
typet::add_subtype(), which better reflects the action taken.
@kroening
protect typet::subtype() nonconst
8b7b7a9 
This protects typet::subtype() nonconst.  There are no remaining uses of the
method outside of the typet class hierarchy.
@kroening kroening assigned peterschrammel and unassigned kroening Sep 9, 2022
@peterschrammel peterschrammel removed their assignment Sep 9, 2022
@kroening kroening merged commit 62f1d5a into develop Sep 9, 2022
@kroening kroening deleted the add_subtype branch September 9, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tautschnig tautschnig tautschnig approved these changes

@peterschrammel peterschrammel peterschrammel approved these changes

@romainbrenguier romainbrenguier Awaiting requested review from romainbrenguier

@chris-ryder chris-ryder Awaiting requested review from chris-ryder

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kroening @tautschnig @peterschrammel