Skip to content

Conversation

@kroening
Copy link
Collaborator

@kroening kroening commented Sep 9, 2022

This adds missing includes for util/narrow.h in two files that use narrow_cast<...>.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This adds missing includes for util/narrow.h in two files that use
narrow_cast<...>.
@kroening kroening marked this pull request as ready for review September 9, 2022 16:07
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #7113 (65784b5) into develop (8b7b7a9) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #7113      +/-   ##
===========================================
- Coverage    77.92%   77.92%   -0.01%     
===========================================
  Files         1576     1576              
  Lines       181645   181644       -1     
===========================================
- Hits        141541   141540       -1     
  Misses       40104    40104              
Impacted Files Coverage Δ
src/solvers/lowering/byte_operators.cpp 92.60% <ø> (ø)
src/solvers/prop/bdd_expr.cpp 93.02% <ø> (ø)
src/solvers/bdd/bdd_miniBDD.h 92.00% <0.00%> (-0.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tautschnig tautschnig merged commit 97df13f into develop Sep 10, 2022
@tautschnig tautschnig deleted the narrow_h branch September 10, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants