Skip to content

Conversation

@kroening
Copy link
Collaborator

@kroening kroening commented Sep 9, 2022

This removes redundant whitespace in the output of the SMT2 backend.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This removes redundant whitespace in the output of the SMT2 backend.
if(first)
first = false;
else
out << ' ';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this space actually needed or is it also redundant?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you'd get ")(" otherwise. Syntactically valid, but not pretty.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. I wasn't aware if the goal was making this prettier or just shorter.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #7116 (6cd20d3) into develop (8b7b7a9) will increase coverage by 0.00%.
The diff coverage is 88.88%.

@@           Coverage Diff            @@
##           develop    #7116   +/-   ##
========================================
  Coverage    77.92%   77.92%           
========================================
  Files         1576     1576           
  Lines       181645   181648    +3     
========================================
+ Hits        141541   141544    +3     
  Misses       40104    40104           
Impacted Files Coverage Δ
src/solvers/smt2/smt2_conv.cpp 68.69% <88.88%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kroening kroening merged commit f3f0044 into develop Sep 9, 2022
@kroening kroening deleted the smt2-whitespace branch September 9, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants