Bug fixes to linking and C/C++ conversion #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
None of the ansi-c/gcc_builtin_headers_* is aligned with the coding standard - I'd thus hope the linter failure can be ignored. |
tautschnig
force-pushed
the
c-linking
branch
2 times, most recently
from
ff3a128 to
5df6af4
Compare
kroening
reviewed
May 25, 2017
src/cpp/cpp_typecheck_type.cpp
Outdated
Collaborator
There was a problem hiding this comment.
What is that needed for?
Collaborator
Author
There was a problem hiding this comment.
It's quite a while since I built that patch, but I suspect that is necessary to make some of the C++ regression tests pass. Also it is the same that the C front-end does.
Collaborator
Author
|
This shouldn't get merged before #876 is merged. |
1 similar comment
Collaborator
Author
|
This shouldn't get merged before #876 is merged. |
Collaborator
|
Needs a rebase, but is then ready to go |
Compilation using goto-cc used to be very noisy. Added source location information to make messages more comprehensible.
Non-symbol types may have been updated during linking; those updates had not been propagated to initializers or goto programs.
This is undocumented, but available as of GCC > 4.4: gcc-mirror/gcc@f0d0d84
Collaborator
Author
|
@kroening Thanks, rebase done. |
This reverts commit a40fc8b.
constructors/destructors are a GCC extension, and their return type must be void as checked earlier. As the type is then replaced by ID_constructor/ID_destructor, and checks on the return type must consider this case.
We cannot arbitrarily convert strings to unicode representation as this would affect their size. Instead, only the unicode portion of a non-wide string must be encoded. As part of this work the code duplication unescape_string/unescape_wide_string is resolved. A new regression test confirms that the previous implementation was broken (and is now fixed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.