Skip to content

disallow flexible array members in unions#7296

Merged
tautschnig merged 1 commit intodevelopfrom
union-flexible
May 6, 2026
Merged

disallow flexible array members in unions#7296
tautschnig merged 1 commit intodevelopfrom
union-flexible

Conversation

@kroening
Copy link
Copy Markdown
Collaborator

@kroening kroening commented Nov 3, 2022

This change yields an error if a flexible array member is used in a union. C11 allows them in structs, but not unions.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig
Copy link
Copy Markdown
Collaborator

This is failing the windows_h_VS_2012 and windows_h_VS_2013 regression tests.

This change yields an error if a flexible array member is used in a union.
C11 allows them in structs, but not unions.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.55%. Comparing base (66f8c1b) to head (eccad80).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7296      +/-   ##
===========================================
- Coverage    80.55%   80.55%   -0.01%     
===========================================
  Files         1707     1707              
  Lines       189012   189016       +4     
  Branches        73       73              
===========================================
+ Hits        152257   152258       +1     
- Misses       36755    36758       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig merged commit 166a7d4 into develop May 6, 2026
43 of 44 checks passed
@tautschnig tautschnig deleted the union-flexible branch May 6, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants