Skip to content

Conversation

@tautschnig
Copy link
Collaborator

Similar to --external-sat-solver: enable calling SMT2 solvers with a non-default name or possibly wrapping a solver to pass additional options.

Fixes: #8720

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig force-pushed the smt-solver-command branch 4 times, most recently from afecf88 to ed58253 Compare November 3, 2025 14:23
@tautschnig tautschnig requested a review from jimgrundy as a code owner November 3, 2025 14:23
@tautschnig tautschnig mentioned this pull request Nov 3, 2025
4 tasks
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 51.72414% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.93%. Comparing base (b6caec4) to head (b8a2281).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/solvers/smt2/smt2_dec.cpp 33.33% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8726      +/-   ##
===========================================
- Coverage    79.93%   79.93%   -0.01%     
===========================================
  Files         1698     1698              
  Lines       187681   187698      +17     
  Branches        73       73              
===========================================
+ Hits        150022   150034      +12     
- Misses       37659    37664       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Similar to `--external-sat-solver`: enable calling SMT2 solvers with a
non-default name or possibly wrapping a solver to pass additional
options.

Fixes: diffblue#8720
@kroening kroening removed their assignment Nov 3, 2025
@tautschnig tautschnig merged commit 2b184cd into diffblue:develop Nov 4, 2025
40 of 41 checks passed
@tautschnig tautschnig deleted the smt-solver-command branch November 4, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce --prover-option flag for CBMC

4 participants