Skip to content

Conversation

@tautschnig
Copy link
Collaborator

Implements byte swapping in the incremental SMT2 decision procedure and adds unit tests. Regression test gcc_bswap1 now passes.

Fixes: #8064

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 97.43590% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.94%. Comparing base (4fe3ade) to head (d5ab4af).

Files with missing lines Patch % Lines
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp 91.30% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8777      +/-   ##
===========================================
+ Coverage    79.93%   79.94%   +0.01%     
===========================================
  Files         1698     1698              
  Lines       187698   187775      +77     
  Branches        73       73              
===========================================
+ Hits        150034   150117      +83     
+ Misses       37664    37658       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Implements byte swapping in the incremental SMT2 decision procedure and
adds unit tests. Regression test `gcc_bswap1` now passes.

Fixes: diffblue#8064
@tautschnig tautschnig force-pushed the fix-8064-inc-smt-bswap branch from 37861c8 to d5ab4af Compare November 30, 2025 22:05
@tautschnig tautschnig marked this pull request as ready for review November 30, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for the GCC __builtin_bswap* intrinsics is unimplemented for the incremental smt2 decision procedure

3 participants