Skip to content

Conversation

@tautschnig
Copy link
Collaborator

We can detect the absence of an entry point much earlier and do not need to perform unnecessary work before inevitably failing.

Fixes: #1847

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig force-pushed the fix-1847-entry-point-logic branch from 6b91499 to e119656 Compare November 30, 2025 21:58
We can detect the absence of an entry point much earlier and do not need
to perform unnecessary work before inevitably failing.

This also fixes a bug where `can_produce_function` did not accurately
reflect what functions could be produced.

Fixes: diffblue#1847
@tautschnig tautschnig force-pushed the fix-1847-entry-point-logic branch from e119656 to c0d7491 Compare December 1, 2025 18:09
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.94%. Comparing base (0985044) to head (c0d7491).

Files with missing lines Patch % Lines
...-checker/single_loop_incremental_symex_checker.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8782   +/-   ##
========================================
  Coverage    79.94%   79.94%           
========================================
  Files         1699     1699           
  Lines       187790   187801   +11     
  Branches        73       73           
========================================
+ Hits        150133   150143   +10     
- Misses       37657    37658    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig marked this pull request as ready for review December 1, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A missing entry point should be reported early

2 participants