Skip to content

Conversation

@tautschnig
Copy link
Collaborator

local_bitvector_analysist previously assumed that pointer arithmetic expressions with 3+ operands always have the pointer operand at position op0(). We do not, however, have such a requirement anywhere, and even if front-ends construct expressions this way then simplification may re-order the operands.

Fixes: #2689

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.93%. Comparing base (4fe3ade) to head (470747a).

Files with missing lines Patch % Lines
src/analyses/local_bitvector_analysis.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8785   +/-   ##
========================================
  Coverage    79.93%   79.93%           
========================================
  Files         1698     1698           
  Lines       187698   187703    +5     
  Branches        73       73           
========================================
+ Hits        150034   150047   +13     
+ Misses       37664    37656    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

`local_bitvector_analysist` previously assumed that pointer arithmetic
expressions with 3+ operands always have the pointer operand at position
`op0()`. We do not, however, have such a requirement anywhere, and even
if front-ends construct expressions this way then simplification may
re-order the operands.

Fixes: diffblue#2689
@tautschnig tautschnig force-pushed the fix-2689-pointer-sum-ops branch from 1d9087e to 470747a Compare November 30, 2025 21:41
@tautschnig tautschnig marked this pull request as ready for review December 2, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

goto-analyser simplify generates binary that can't be analyzed with goto-instrument

2 participants