Prevent orphan child processes when CBMC parent is killed#8900
Draft
tautschnig wants to merge 1 commit intodiffblue:developfrom
Draft
Prevent orphan child processes when CBMC parent is killed#8900tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
Add prctl(PR_SET_PDEATHSIG, SIGTERM) in the child process fork path so the kernel sends SIGTERM to the child (e.g., z3) when the parent dies. This prevents orphan processes from persisting indefinitely after CBMC is killed with SIGKILL. The prctl call is guarded by #ifdef __linux__ since it is Linux-specific. Fixes: diffblue#8485
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8900 +/- ##
===========================================
- Coverage 80.41% 80.41% -0.01%
===========================================
Files 1703 1703
Lines 188398 188399 +1
Branches 73 73
===========================================
- Hits 151502 151499 -3
- Misses 36896 36900 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add prctl(PR_SET_PDEATHSIG, SIGTERM) in the child process fork path so the kernel sends SIGTERM to the child (e.g., z3) when the parent dies. This prevents orphan processes from persisting indefinitely after CBMC is killed with SIGKILL.
The prctl call is guarded by #ifdef linux since it is Linux-specific.
Fixes: #8485