Remove deprecated add_axioms_from_bool method#8919
Open
tautschnig wants to merge 1 commit intodiffblue:developfrom
Open
Remove deprecated add_axioms_from_bool method#8919tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8919 +/- ##
===========================================
- Coverage 80.46% 80.46% -0.01%
===========================================
Files 1704 1704
Lines 188665 188659 -6
Branches 73 73
===========================================
- Hits 151805 151799 -6
Misses 36860 36860 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated string_constraint_generatort::add_axioms_from_bool(array_string_exprt, exprt) helper and inlines its (String.format-related) boolean formatting constraints directly at the call site, aligning with Issue #8022’s deprecation cleanup.
Changes:
- Removed the deprecated
add_axioms_from_bool(const array_string_exprt &, const exprt &)declaration and definition. - Inlined the
"true"/"false"constraint generation intostring_format_builtin_function.cppfor the BOOLEAN format specifier.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/solvers/strings/string_format_builtin_function.cpp |
Inlines the boolean-to-string axioms previously implemented by the deprecated helper. |
src/solvers/strings/string_constraint_generator.h |
Removes the deprecated overload declaration from the generator interface. |
src/solvers/strings/string_constraint_generator_valueof.cpp |
Removes the deprecated overload implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Inline the body of the deprecated 2-argument add_axioms_from_bool at its sole call site in string_format_builtin_function.cpp. Also remove the orphaned 1-argument overload declaration which had no definition or callers. Fixes: diffblue#8022 Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
c049a3d to
af83392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the deprecated add_axioms_from_bool(array_string_exprt, exprt) method and inlined its logic at the call site in string_format_builtin_function.cpp
Fixes: #8022