Unit tests: verify complementary pair detection in AND/OR#8982
Merged
tautschnig merged 1 commit intodiffblue:developfrom Apr 30, 2026
Merged
Unit tests: verify complementary pair detection in AND/OR#8982tautschnig merged 1 commit intodiffblue:developfrom
tautschnig merged 1 commit intodiffblue:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8982 +/- ##
========================================
Coverage 80.50% 80.50%
========================================
Files 1704 1704
Lines 188796 188816 +20
Branches 73 73
========================================
+ Hits 151993 152013 +20
Misses 36803 36803 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kroening
approved these changes
Apr 27, 2026
Collaborator
|
We'll want a variant of |
Add unit tests confirming that the simplifier detects complementary pairs in boolean AND/OR expressions: A || !A -> true A && !A -> false A || (B || !A) -> true (after flattening by join_operands) This is already handled by the existing 'search for a and !a' loop in simplify_boolean(). The tests document and protect this behavior. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
994b4ad to
a5834d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit tests confirming that the simplifier detects complementary pairs in boolean AND/OR expressions:
A || !A -> true
A && !A -> false
A || (B || !A) -> true (after flattening by join_operands)
This is already handled by the existing 'search for a and !a' loop in simplify_boolean(). The tests document and protect this behavior.