chore(renovate): group Storybook packages so they bump in lockstep#257
Open
dormouse-bot wants to merge 1 commit into
Open
chore(renovate): group Storybook packages so they bump in lockstep#257dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
1 task
Deploying mouseterm with
|
| Latest commit: |
9f91fb3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f669c83e.mouseterm.pages.dev |
| Branch Preview URL: | https://chore-renovate-group-storybo.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Renovate is splitting the Storybook monorepo into one PR per package. The 10.5.0 bump currently opens as three separate, mutually-incompatible PRs — #254 (
@storybook/react), #255 (@storybook/react-vite), and #256 (storybook) — and each one alone leaves Storybook in a broken mixed-version state:@storybook/react@10.5.0's preset importsgetComponentIdFromEntryfromstorybook/internal/common, which the 10.4.6 core doesn't export, so the React preset fails to load.storybook buildstill exits 0 (it only logsFailed to load preset), and the onlybuild-storybookjob — Chromatic — is gated onpaths: lib/**, so a lockfile-only bump never runs it. The breakage is invisible to CI.Fix
Add a
storybookgroup sostorybookand all@storybook/**packages bump together in a single PR — the same treatmentreact-routerandtailwindcssalready get, and for the same stated reason ("framework packages are peered and released together; do not split runtime and build tooling"). Storybook has the identical lockstep property.Once this merges, Renovate will supersede #254/#255/#256 with one grouped 10.5.0 PR that installs and builds cleanly (verified locally: aligning all three to 10.5.0 removes the preset error).
Details and reproduction are on #255.