Remove 35 redundant stories to reduce snapshot cost and review repetition

[nedtwigg]

Remove redundant Storybook fixtures to reduce snapshot volume and review repetition. The library goes from 300 to 267 stories (11% fewer Chromatic snapshot candidates); the separate Canopy lab goes from 6 to 4.

Removal commits explain the overlap and name retained coverage. The canonical desktop selection popup remains the isolated baseline; existing unit tests cover the browser-reserved shortcut variant. The unused long-running output fixture and its structure-only test are also removed. Cuts include identical fixtures, text-only variants of the same presentation, and cases already exercised by a retained integration or state gallery. Distinct alert rotations, theme variants, pairing outcomes, and layout stress cases remain. The Canopy spec inventory is updated.

Validation:

• Library and Canopy Storybook builds and typechecks pass.
• Spec lint and its self-tests pass.
• All 22 story references in the pairing walkthrough resolve.
• 31 retained replacement stories finish their local browser renders and play functions; the restored desktop popup is checked separately.
• All 36 focused popup, capture, and fake-scenario tests pass.

Chromatic savings depend on which stories each build captures; 11% is the reduction in library story count, not a measured billing reduction.

[cloudflare-workers-and-pages]

Deploying mouseterm with    Cloudflare Pages

Latest commit:	699cd60
Status:	✅  Deploy successful!
Preview URL:	https://69c91130.mouseterm.pages.dev
Branch Preview URL:	https://storybook-audit.mouseterm.pages.dev

View logs

[dormouse-bot]

Reviewing as a draft — flagging anything that looks worth a quick fix. Mark ready for a full review.

I spot-checked the removals against the code they render rather than the commit messages, and all but one hold up: BlockedWithLabel is byte-identical to Blocked (BlockedTitle ignores displayText entirely), NotepadEmpty/NotepadMinimalWidthEmpty have exactly the args and parameters of AlertEnabled/MinimalWidthWithAlert, Door's OSC_NOTIF_BUSY and COMMAND_EXIT_ARMED both resolve to the same rotate-45 as BUSY in bellIconClass, PushEnabled differs from PushManyDevices only in a join(', '), DevServerConnected is the meta's default args, and the canopy showAtlas stories render the terminal and the atlas, so they're strict supersets of the two cut. ConnectedView still renders the pocket-app PocketWall, so SingleSession really was covered. All 22 <Canvas of=…> references in docs/stories/pairing.mdx resolve, no removed name survives anywhere in the repo, no import or module-level declaration is orphaned, and the six sibling lints plus spec-lint pass. ReducedMotionRinging is a fair cut too — preview.ts sets cfg.alert.ringingPaused = true under Chromatic, so it snapshotted identically to AlertRinging.

SelectionPopup: the cut took the default and kept the special case

(Would have been inline, but the hunk is deletion-only so there's no right-side line to anchor to.)

lib/src/stories/SelectionPopup.stories.tsx is left with the website variant and Mobile, and no story for the popup every real desktop host draws. ChordReservedByBrowser sets platform.browserReservesNotepadChord, which makes isNotepadChordBound() false in SelectionPopup.tsx, so notepadShortcut is null and the third button renders without its [Cmd+N]. That absent badge is the only difference from the story being deleted — which is exactly the "text-only variant of the same presentation" criterion the rest of this PR cuts on, applied to the wrong one of the pair.

Swapping which one survives keeps the count at 267 and keeps the canonical rendering — replace the ChordReservedByBrowser comment and story with:

// Desktop: all three buttons carry their keyboard shortcuts and, for a downward
// drag, sit below the selection. The fake adapter has an in-memory notepad
// archive, so Add to notepad is present here as it is in every real desktop host.
export const Desktop: Story = {
  args: {
    id: 'selection-popup-desktop',
    selection: SELECTION,
  },
};

Two smaller leftovers

Both outside the diff, happy to push either if you want them:

• SCENARIO_LONG_RUNNING in lib/src/lib/platform/fake-scenarios.ts has no render site left — TerminalPane's LongRunning was the only one. What remains is the barrel re-export and its own structure test in fake-scenarios.test.ts, which validates the shape of a fixture nothing draws.
• ReducedMotionRinging was the repo's only reducedMotion: true, so the reducedMotion prop and argType on the TerminalPaneHeader story frame are now controls-panel-only. That matches how Door.stories.tsx already carried it, so it's consistent rather than broken — just worth knowing the static coverage went with it.

Two notes on the framing

The canopy cuts don't touch snapshot cost at all: chromatic.yml runs with workingDir: lib behind a lib/**, docs/stories/** paths filter, so those two stories were never billed. And with onlyChanged: true, this PR's own build re-snapshots the remaining stories in all 19 touched files, so the payoff is on later builds, not this one. Neither contradicts the PR body, which is already careful about the 11% being a story count.

[nedtwigg]

Addressed the draft review in 0ff30fa and 699cd60:

• Restored SelectionPopup/Desktop and removed ChordReservedByBrowser plus its unused story plumbing. SelectionPopup.test.tsx still asserts that a browser-reserved chord hides only the notepad shortcut; capture.test.ts covers the adapter flag. Story count remains 267.
• Removed the unused SCENARIO_LONG_RUNNING, its barrel export, and its structure-only test.
• Kept the reducedMotion controls for manual inspection, consistent with the Door stories. The removed story never exercised the real media preference and duplicated Chromatic's animation freeze.

Validation: 36 focused tests, library typecheck, and Storybook build pass. The restored desktop story finishes its play function and displays all three shortcut labels. Canopy savings remain described separately from the library snapshot-candidate reduction.

[dormouse-bot]

Confirmed at 699cd60a — all three are resolved, and I have nothing further.

The swap is clean: SelectionPopup.stories.tsx is now Desktop + Mobile, the reservesChord prop and the getPlatform import went with it, and nothing in the repo still names ChordReservedByBrowser, reservesChord, or selection-popup-reserved-chord. The two tests you cite do carry the variant — SelectionPopup.test.tsx mocks isNotepadChordBound false and asserts the [Cmd+N] badge goes invisible while the button stays, and capture.test.ts sets browserReservesNotepadChord on the adapter against the real isNotepadChordBound. Chromatic published 267 stories on this head, so the count held.

SCENARIO_LONG_RUNNING is gone from the fixture, the barrel, and the structure test with no reference left anywhere.

Keeping the reducedMotion controls is fine — that note was informational, not a request. Build & Test and Visual Regression Tests were still running when I wrote this.