Skip to content

Conversation

@sbillinge
Copy link
Contributor

@Tieqiong please could you review this and see if you see any issues with it?

@github-actions
Copy link

Warning! No news item is found for this PR. If this is a user-facing
change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.
For best practices, please visit
https://scikit-package.github.io/scikit-package/snippets/news-file-format.html#how-do-i-create-a-news-file.

@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.97%. Comparing base (e88eb06) to head (689af53).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files           6        6           
  Lines        1267     1270    +3     
=======================================
+ Hits         1254     1257    +3     
  Misses         13       13           
Files with missing lines Coverage Δ
tests/test_exceptions.py 99.80% <100.00%> (+<0.01%) ⬆️
tests/test_pdffit.py 99.76% <100.00%> (+<0.01%) ⬆️
tests/test_phase_fractions.py 98.70% <100.00%> (ø)
tests/test_shape_factors.py 99.53% <100.00%> (+<0.01%) ⬆️
tests/test_version.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevenhua0320
Copy link
Contributor

@sbillinge I had a conversation with CHATGPT and it says we should not make edits to ‎src/diffpy/__init__.py as it will load other subpackages provided by other location in sys.path. Maybe we also need to revert that back as it is auto-deleted by scikit-package.

@sbillinge sbillinge merged commit 4773715 into main Nov 23, 2025
6 of 7 checks passed
@sbillinge sbillinge deleted the migration branch November 23, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants